* David.Comay at sun.com <David.Comay at sun.com> [2007-05-22 18:08]:
> >http://cr.opensolaris.org/~sch/corewhich-0517/

  I received a private review which caught most of these, so I'll just
  mention the ones that hadn't already been fixed.

> usr/src/cmd/which/Makefile.sfw
> 
>       Line 29 - Unless I missed the loop, I believe this setting of
>       SHELL is unnecessary (carryover from other Makefile.sfw?)

  Deleted.

> usr/src/pkgdefs/SUNWgnu-coreutils/pkginfo.tmpl
> usr/src/pkgdefs/SUNWgnu-which/pkginfo.tmpl
> 
>       Line 34 - I've forgotten how SUNW_PRODNAME is used but "SunOS"
>       is the typical value here (although it appears "webmin" also
>       defines a customized value.)

  Fixed in both.

  - Stephen
  
-- 
sch at sun.com  http://blogs.sun.com/sch/

Reply via email to