> I've put a webrev for bumping Tcl/Tk and moving to /usr at:
> http://cr.grommit.com/~dermot/tcltk-01/
Some general notes first:
1) Be sure to file a CR under solaris/manpage/section0 to
request that /usr/share/man/man.cf be updated to "know" about
the new sections, 1t, 3tcl and 3tk.
2) Your webrev only listed "6571121 Bump Tcl/Tk to 8.4.14" but
not the relevant ARC case, "PSARC 2007/317 Tcl/Tk upgrade to
8.4.14". Be sure to include both lines when you check in the
files and in your putback comments.
usr/src/lib/tcl/Makefile.sfw
Line 22 - Nit, but you're adding an extraneous # line here.
usr/src/lib/tcl/sunman-stability
Lines 1 and 22 - Nit, but you're adding extraneous # lines
here.
usr/src/lib/tcl/tclsed
Lines 2 and 22 - Nit, but you're adding extraneous # lines
here.
usr/src/lib/tk/Makefile.sfw
Line 33 - Why are you leaving in the "-L${ROOT}/usr/lib" part
of LD_OPTIONS?
usr/src/lib/tk/sunman-stability
Lines 1 and 22 - Nit, but you're adding extraneous # lines
here.
usr/src/lib/tk/tksed
Lines 2 and 22 - Nit, but you're adding extraneous # lines
here.
usr/src/pkgdefs/SUNWTcl/prototype_com
Please sort the path names (sort +2).
usr/src/pkgdefs/SUNWTk/prototype_com
Please sort the path names (sort +2).
> - Tcl and Tk provide stub libraries (libtclstub8.4.a & libtkstub8.4.a), which
> we previously
> included in SUNWTcl/Tk, but I have removed them here as shipping static
> libs seems a bad idea. If these really need to be included, please let me
> know.
> man -M /usr/sfw/share/man Tcl_InitStubs for more details.
That seems OK by me.
> - As previously, I have appended the stability classification to all (337)
> manpages.
> Is this necessary, or is it sufficient to just do the main pages and not the
> API/shell ones?
I think each of them should include the stability classification.
> - Any other known deps. on Tcl in SFW that might need to be updated?
Have you checked for any dependencies throughout the WOS?
> - I have not included 64-bit libs - is there any call for these?
I would think this would be desirable but I don't know if any such
applications exist for Tcl/Tk. I'm OK with seeing this as some
subsequent work.
dsc
