Hi Vivek,
Below are few more comments:
1. In Makefile.sfw,
- Instead of calling out two commands - gzip and gtar, you could
just use one command i.e gtar with 'z' option to unzip the tarball.
- "install_h" target is missing. I presume the nightly would fail
without this target. Please check.
2. In usr/src/lib/tipc/patch/Makefile.master.patch, you could probably
change
15 -TIPC_LIBDIR = $(TIPC_ROOTDIR)/lib
16 +TIPC_HDRDIR = usr/include
to something like
15 -TIPC_LIBDIR = $(TIPC_ROOTDIR)/lib
16 +TIPC_HDRDIR = usr/include*/net/tipc*
and get rid of below patches and may be even more patches. Please check.
usr/src/lib/tipc/patch/demo.benchmark.Makefile.com.patch
usr/src/lib/tipc/patch/demo.connection_demo.Makefile.com.patch
usr/src/lib/tipc/patch/demo.hello_world.Makefile.com.patch
usr/src/lib/tipc/patch/demo.multicast_demo.Makefile.com.patch
usr/src/lib/tipc/patch/demo.stream_demo.Makefile.com.patch
usr/src/lib/tipc/patch/demo.topology_subscr_demo.Makefile.com.patch
3. Are 64 bit tipc-config binaries not required ? If they do, then
please make required modifications to prototype_i386 and prototype_sparc
files.
4. Also does 'tipc-config' have a man page ?
Thanks,
Srirama
Vivek Titarmare said the following on Wednesday 29 April 2009 06:54 PM:
>
> I have posted a webrev for package "tipc" which I am porting to Neveda
> and would like to request a code review. Please see below link
>
>
>
> http://cr.opensolaris.org/~vivekrt/6833850-tipc/
> <http://cr.opensolaris.org/%7Evivekrt/6833850-tipc/>
>
>
>
>
>
> Thanks,
>
> ~Vivek R. Titarmare
>
>
>
>
>
>
>
