Hi Paul, For point 1: since this package has a LGPL license the SUN disclaimer is required.
For point 2: Yes, it works with jar. Should I be changing it to UNPACKARCHIVE? Let me know. Thanks, ~Vivek R. Titarmare -----Original Message----- From: Paul Cunningham [mailto:[email protected]] Sent: Friday, May 15, 2009 4:19 PM To: Vivek Titarmare Cc: sfwnv-discuss at opensolaris.org Subject: Re: [sfwnv-discuss] Request code review for "jrexx" Vivek, mainly looks good to me, a few comments below .... Paul Vivek Titarmare wrote: > I have posted a webrev for package "jrexx" which I am porting to Neveda > and would like to request a code review. Please see the link below > > http://cr.opensolaris.org/~vivekrt/6835983-jrexx/ 1. usr/src/pkgdefs/SUNWjrexx/copyright Does this need Sun disclaimer stuff added? 2. usr/src/lib/jrexx/Makefile.sfw Line ... 53 jar xf ../$(TARBALL) ;) is this correct for a .zip file? END -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
