Vivek, This looks okay to me now apart from the METADATA stuff, also an additional minor comment see below ..
Paul Vivek Titarmare wrote: > > Yes, I have changed the METADATA file accordingly. However, I faced one > issue which is PROGRAM variable which was not present in the METADATA sample > provided in the url. PROGRAM is required for the COMPONENT_NAME in the > Makefile.sfw. I had to add the PROGRAM again in the METADATA to get the > Makefile.sfw working as expected. > Pl. suggest for any other solutions. > > Webrev is uploaded with all the changes. > (http://cr.opensolaris.org/~vivekrt/6833850-tipc/ ) >> Vivek Titarmare wrote: >>> I have posted a webrev for package "tipc" which I am porting to Neveda >>> and would like to request a code review. Please see below link >>> >>> http://cr.opensolaris.org/~vivekrt/6833850-tipc/ >> 1. usr/src/lib/tipc/Makefile.sfw Cosmetic: add white-space after the ':' on line .. 79 install:all -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
