Vivek, This mainly looks good, see comments below ...
Paul Vivek Titarmare wrote: > I have posted a webrev for package "trove" which I am porting to Neveda > and would like to request a code review. Please see the link below > > http://cr.opensolaris.org/~vivekrt/6835980-trove/ 1. GNU Trove The source package's home-page seems to indicate that this is GNU; so just a thought, should this provide symbolic links in /usr/gnu ? 2. usr/src/lib/trove/METADATA Update as per heads-up 3. usr/src/pkgdefs/SUNWtrove/copyright Does this need a Sun disclaimer statement added ? 4. usr/src/pkgdefs/SUNWtrove/depend Remove the build time dependencies for ant, etc. END -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
