Mark, See comments below ...
paul Mark Phalan wrote: > Find below two webrevs (one each for ON and SFW) for review which move > OpenSSL from ON to SFW. > > http://cr.opensolaris.org/~mbp/6806387-move_openssl/ This looks okay to me, but I'm not sure what the new file is for ? ... usr/src/stand/lib/openssl/Makefile > http://cr.opensolaris.org/~mbp/6806387-move_openssl_SFW/ 1. usr/src/lib/openssl/METADATA Change this so it conforms to that defined in .. "http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines"; 2. Top of files (various files) Change the tops of files so that they conform to the prototypes in ... "http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/"; 3. usr/src/lib/openssl/Makefile.sfw Delete as is already defined in Makefile.master ... 26 SHELL=/usr/bin/ksh93 Lines ... 81 $(VER64)/Configure: $(VER).tar.gz 182 mkdir -p tmp 183 gzip -dc $(VER).tar.gz | .... replace '$(VER).tar.gz' with '$(TARBALL)' and else where. 4. usr/src/lib/openssl/install-sfw Lines ... 35 mkdir -p ${LIBDIR} 36 mkdir -p ${BINDIR} 37 mkdir -p ${ROOT}/etc/sfw 38 mkdir -p ${ROOT}/usr/sfw/bin 39 mkdir -p ${ROOT}/usr/sfw/lib these should already be in Targetdirs so are not required here, delete Line ... 56 chmod 0755 $bin do not install with write permission bit set Line .. 80 gpatch ${ROOT}/usr/include/openssl/opensslconf.h \ opensslconf.patch shouldn't this be done before its installed into the proto area? Lines 67, 68, are there any libraries that need symbolic links into /usr/sfw/lib ? 5. usr/src/lib/openssl/install-sfw-64 Lines ... 35 mkdir -p ${LIBDIR} 36 mkdir -p ${BINDIR} 37 mkdir -p ${USRLIBDIR}/pkgconfig 38 mkdir -p ${ROOT}/usr/sfw/bin/${MACH64} 39 mkdir -p ${ROOT}/usr/sfw/lib/${MACH64} these should already be in Targetdirs so are not required here, delete. Line ... 55 chmod 0755 $bin do not install with write permission bit set I'm not sure about this ... 41 mv -f ${ROOT}/usr/bin/openssl ${BINDIR}/openssl 42 mv -f ${ROOT}/usr/lib/libcrypto.so* ${LIBDIR}/ 43 mv -f ${ROOT}/usr/lib/libssl.so* ${LIBDIR}/ 44 mv -f ${ROOT}/usr/lib/pkgconfig/openssl.pc ... isn't it moving the 32 bit stuff? 6. patches I haven't looked at them; I've assumed they are correct 7. usr/src/lib/openssl/llib-lcrypto & usr/src/lib/openssl/llib-lssl Shouldn't this have the CDDL header stuff? 8. usr/src/pkgdefs/Makefile This needs resyncing with the gate, so it doesn't look as though you are changing other stuff. 9. usr/src/pkgdefs/SUNWopenssl-commands/Makefile & usr/src/pkgdefs/SUNWopenssl-include/Makefile Does it need these lines ? ... 29 LICENSEFILES += ../../common/openssl/LICENSE 30 CDDL= 10. usr/src/pkgdefs/SUNWopenssl-commands/depend & all others 'depend' files Copyright and ident are in the wrong place 11. usr/src/pkgdefs/SUNWopenssl-commands/pkginfo.tmpl & all others Add version to the of DESC= line, eg. ... DESC="............ (0.9.8a)" 12. usr/src/pkgdefs/SUNWopenssl-commands/prototype_com & usr/src/pkgdefs/SUNWopenssl-commands/prototype_sparc & usr/src/pkgdefs/SUNWopenssl-commands/prototype_i386 Move creation of symbolic link to after its target is put in place. 13. SUNW*/copyright It's not normal to include this unless it refers to the source ... 1 Copyright 2009 Sun Microsystems, Inc. All rights reserved. 2 Use is subject to license terms. 14. SUNW*/depend Its normal to include all the dependencies from the default 'depend' also (as appropriate) 15. usr/src/pkgdefs/SUNWopenssl-include/prototype_com & usr/src/pkgdefs/SUNWopenssl-include/prototype_i386 & usr/src/pkgdefs/SUNWopenssl-include/prototype_sparc Do not install files into /usr with the write permission bit set. 16. usr/src/pkgdefs/SUNWopensslr/postinstall & usr/src/pkgdefs/SUNWopensslr/preinstall Why /sbin/sh instead of /bin/sh ? 17. usr/src/pkgdefs/SUNWopensslr/prototype_com & usr/src/pkgdefs/SUNWopensslr/prototype_i386 & usr/src/pkgdefs/SUNWopensslr/prototype_sparc Do all the files need the write permission bit set ? 18. usr/src/pkgdefs/SUNWopensslr/r.opensslcnf Is this required, it does not seem to do anything? 19. usr/src/pkgdefs/SUNWopenssl-libraries/prototype_com & usr/src/pkgdefs/SUNWopenssl-libraries/prototype_i386 & usr/src/pkgdefs/SUNWopenssl-libraries/prototype_sparc Why are there no libraries in ? ... /usr/sfw/lib/sparcv9 /usr/sfw/lib/amd64 /usr/sfw/lib END -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
