On Tue, 2009-05-12 at 13:48 +0200, Mark Phalan wrote:
> On Tue, 2009-05-12 at 09:25 +0100, Paul Cunningham wrote:
...
> ...
> > >> 14. SUNW*/depend
> > >> Its normal to include all the dependencies from
> > >> the default 'depend' also (as appropriate)
> > >>
> > >
> > > Where is the default 'depend'?
> >
> > "http://src.opensolaris.org/source/xref/sfw/usr/src/pkgdefs/common_files/depend";
>
> How can I use this? (It looks like it is probably suitable for
> SUNWopenssl-man).
Fixed.
>
> >
> > >> 15. usr/src/pkgdefs/SUNWopenssl-include/prototype_com
> > >> & usr/src/pkgdefs/SUNWopenssl-include/prototype_i386
> > >> & usr/src/pkgdefs/SUNWopenssl-include/prototype_sparc
> > >> Do not install files into /usr with the write permission
> > >> bit set.
> > >
> > > I probably agree with you that this is a bug however most header files
> > > in /usr/include have the write bit set already:
> > >
> > > $ find /usr/include -type f -perm 644 | wc -l
> > > 9094
> > >
> > > I'd rather leave it as is for the moment and fix it in a follow-up push
> > > after the move. OpenSSL is a very used piece of software in the core of
> > > Solaris, minimizing impact when moving from ON to SFW is a high priority
> > > to me.
> >
> > You will probably/must change this otherwise your RTI will get rejected;
> > see any recent integration into the sfw gate: all files installed into
> > /usr do not have the write permission set. Ask Norm.Jacobs at Sun.COM to
> > confirm.
>
> I've updated the permissions. I'll re-run some tests.
Fixed.
>
> >
> > >> 16. usr/src/pkgdefs/SUNWopensslr/postinstall
> > >> & usr/src/pkgdefs/SUNWopensslr/preinstall
> > >> Why /sbin/sh instead of /bin/sh ?
> > >
> > > I don't know - I just moved it from ON. I'll ask the original author.
>
> I'll let you know when I get a reply.
>From the developer:
"When I wrote my postinstall script, I looked at other postinstall
scripts using removef. Somehow I picked one (probably SUNWnxge) that
used /sbin/sh for its shell reference. I see no problem with using
/bin/sh."
So I can change it if required. On the other hand /bin/sh is a symlink
to /sbin/sh so it shouldn't make much difference either way.
An updated webrev is in the usual place. I had to make one more change -
"Targetdirs" was updated to create /usr/sfw/bin/${MACH64}.
Thanks,
-M
