On Tue, 2009-05-12 at 09:25 +0100, Paul Cunningham wrote: > See below ... ... > > > >> 8. usr/src/pkgdefs/Makefile > >> This needs resyncing with the gate, so it doesn't look > >> as though you are changing other stuff. > > This still doesn't look right
Fixed. ... > >> 14. SUNW*/depend > >> Its normal to include all the dependencies from > >> the default 'depend' also (as appropriate) > >> > > > > Where is the default 'depend'? > > "http://src.opensolaris.org/source/xref/sfw/usr/src/pkgdefs/common_files/depend"; How can I use this? (It looks like it is probably suitable for SUNWopenssl-man). > > >> 15. usr/src/pkgdefs/SUNWopenssl-include/prototype_com > >> & usr/src/pkgdefs/SUNWopenssl-include/prototype_i386 > >> & usr/src/pkgdefs/SUNWopenssl-include/prototype_sparc > >> Do not install files into /usr with the write permission > >> bit set. > > > > I probably agree with you that this is a bug however most header files > > in /usr/include have the write bit set already: > > > > $ find /usr/include -type f -perm 644 | wc -l > > 9094 > > > > I'd rather leave it as is for the moment and fix it in a follow-up push > > after the move. OpenSSL is a very used piece of software in the core of > > Solaris, minimizing impact when moving from ON to SFW is a high priority > > to me. > > You will probably/must change this otherwise your RTI will get rejected; > see any recent integration into the sfw gate: all files installed into > /usr do not have the write permission set. Ask Norm.Jacobs at Sun.COM to > confirm. I've updated the permissions. I'll re-run some tests. > > >> 16. usr/src/pkgdefs/SUNWopensslr/postinstall > >> & usr/src/pkgdefs/SUNWopensslr/preinstall > >> Why /sbin/sh instead of /bin/sh ? > > > > I don't know - I just moved it from ON. I'll ask the original author. I'll let you know when I get a reply. > > > > >> 17. usr/src/pkgdefs/SUNWopensslr/prototype_com > >> & usr/src/pkgdefs/SUNWopensslr/prototype_i386 > >> & usr/src/pkgdefs/SUNWopensslr/prototype_sparc > >> Do all the files need the write permission bit > >> set ? > > > > See (15). All libs in /lib have 755 perms. > > >> 18. usr/src/pkgdefs/SUNWopensslr/r.opensslcnf > >> Is this required, it does not seem to do anything? > > > > See (16). >From the original author: " nothing in my notes, nothing in my saved mails. I'd suggest to remove it but on the other hand, I don't usually just add stuff without a reason. I'm sorry I'm afraid I can't help you here :-( given the fact that you won't do all the testing I did I'd just leave it there and explain it to code reviewers accordingly..." I'd prefer to leave it there for the moment. It certainly can't do any harm. I'll take a look at it later on and see if it can be safely removed. ... Thanks, -M
