See below ... Mark Phalan wrote: >Yes, same place as before: > http://cr.opensolaris.org/~mbp/6806387-move_openssl_SFW/
>> Mark Phalan wrote: >>> Find below two webrevs (one each for ON and SFW) for review which move >>> OpenSSL from ON to SFW. >>> >>> http://cr.opensolaris.org/~mbp/6806387-move_openssl/ >> This looks okay to me, but I'm not sure what the new file >> is for ? ... >> usr/src/stand/lib/openssl/Makefile > > The new Makefile is there to pull in the openssl header files so that > WAN boot can still build. As the move removes openssl from ON the proto > area won't have (and shouldn't have) the header files. > >>> http://cr.opensolaris.org/~mbp/6806387-move_openssl_SFW/ >> 2. Top of files (various files) >> Change the tops of files so that they conform to the >> prototypes in ... >> "http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/"; > > I mostly just modified the Makefiles. Do you see any other files which > need modification? There are a few that still don't conform fully - but its cosmetic, so I leave it to you to fix or not > >> 8. usr/src/pkgdefs/Makefile >> This needs resyncing with the gate, so it doesn't look >> as though you are changing other stuff. This still doesn't look right >> 9. usr/src/pkgdefs/SUNWopenssl-commands/Makefile >> & usr/src/pkgdefs/SUNWopenssl-include/Makefile >> Does it need these lines ? ... >> 30 CDDL= > I've left the CDDL=. It seems to be a common usage in packages in ON. I've never seen it in sfw stuff >> 14. SUNW*/depend >> Its normal to include all the dependencies from >> the default 'depend' also (as appropriate) >> > > Where is the default 'depend'? "http://src.opensolaris.org/source/xref/sfw/usr/src/pkgdefs/common_files/depend"; >> 15. usr/src/pkgdefs/SUNWopenssl-include/prototype_com >> & usr/src/pkgdefs/SUNWopenssl-include/prototype_i386 >> & usr/src/pkgdefs/SUNWopenssl-include/prototype_sparc >> Do not install files into /usr with the write permission >> bit set. > > I probably agree with you that this is a bug however most header files > in /usr/include have the write bit set already: > > $ find /usr/include -type f -perm 644 | wc -l > 9094 > > I'd rather leave it as is for the moment and fix it in a follow-up push > after the move. OpenSSL is a very used piece of software in the core of > Solaris, minimizing impact when moving from ON to SFW is a high priority > to me. You will probably/must change this otherwise your RTI will get rejected; see any recent integration into the sfw gate: all files installed into /usr do not have the write permission set. Ask Norm.Jacobs at Sun.COM to confirm. >> 16. usr/src/pkgdefs/SUNWopensslr/postinstall >> & usr/src/pkgdefs/SUNWopensslr/preinstall >> Why /sbin/sh instead of /bin/sh ? > > I don't know - I just moved it from ON. I'll ask the original author. ? > >> 17. usr/src/pkgdefs/SUNWopensslr/prototype_com >> & usr/src/pkgdefs/SUNWopensslr/prototype_i386 >> & usr/src/pkgdefs/SUNWopensslr/prototype_sparc >> Do all the files need the write permission bit >> set ? > > See (15). See my reply >> 18. usr/src/pkgdefs/SUNWopensslr/r.opensslcnf >> Is this required, it does not seem to do anything? > > See (16). ? > >> 19. usr/src/pkgdefs/SUNWopenssl-libraries/prototype_com >> & usr/src/pkgdefs/SUNWopenssl-libraries/prototype_i386 >> & usr/src/pkgdefs/SUNWopenssl-libraries/prototype_sparc >> Why are there no libraries in ? ... >> /usr/sfw/lib/sparcv9 >> /usr/sfw/lib/amd64 >> /usr/sfw/lib > > This looks like a bug introduced with: > 6449514 move OpenSSL from /usr/sfw to /usr, /lib > > I'll investigate and file a bug but may not fix that issue with my > putback. would probably be easier to fix it now Paul -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
