Vivek,

Mainly looks okay to me, see comments below ...

Paul

Vivek Titarmare wrote:
> I have posted a webrev for package "commons-lang" which I am porting to 
> Neveda and would like to request a code review. Please see the link below 
> 
> http://cr.opensolaris.org/~vivekrt/6835995-commons-lang/

1. usr/src/lib/commons-lang/METADATA
    This need updating as per ...
      "http://wikis.sun.com/display/SFWNotes/METADATA";

2. usr/src/pkgdefs/SUNWcommons-lang/pkginfo.tmpl
    Version number is wrong on DESC= line

END
-- 
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Business Unit

Reply via email to