Hi Paul, Changes are done and have re uploaded the webrev. http://cr.opensolaris.org/~vivekrt/6835995-commons-lang/
Thanks, ~Vivek R. Titarmare -----Original Message----- From: Paul Cunningham [mailto:[email protected]] Sent: Wednesday, May 13, 2009 6:46 PM To: Vivek Titarmare Cc: sfwnv-discuss at opensolaris.org Subject: Re: [sfwnv-discuss] Request code review for "commons-lang" Vivek, Mainly looks okay to me, see comments below ... Paul Vivek Titarmare wrote: > I have posted a webrev for package "commons-lang" which I am porting to > Neveda and would like to request a code review. Please see the link below > > http://cr.opensolaris.org/~vivekrt/6835995-commons-lang/ 1. usr/src/lib/commons-lang/METADATA This need updating as per ... "http://wikis.sun.com/display/SFWNotes/METADATA"; 2. usr/src/pkgdefs/SUNWcommons-lang/pkginfo.tmpl Version number is wrong on DESC= line END -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
