Hi Paul, Thanks for your review. Please see my replies below.
Paul Cunningham wrote: > Christopher, > > This mainly looks good to me, see below foe a few comments ... > > Paul > > Christopher Mi wrote: >> >> Please help to review pen, a load balancer for "simple" tcp based >> protocols. >> >> The home page is at, >> http://siag.nu/pen/ >> >> The webrev is at, >> http://cr.opensolaris.org/~mishuang/pen/ > > 1. usr/src/cmd/pen/METADATA > Please check the SRC: ftp link is correct because it > did not work when I tried it (server may have been down > though). > I tried again. It works. Maybe you need to set ftp_proxy :-) > 2. usr/src/cmd/pen/Makefile.sfw > Lines 44-46, do you need to use the protofix here > because you only seem to be installing stuff in > using install-sfw with _install so the permissions > should be correct ? I delete those lines. > > 3.usr/src/pkgdefs/SUNWpen/Makefile > You have your own depend file, so delete .. > 31 DATAFILES = depend Done. > > 4. usr/src/pkgdefs/SUNWpen/depend > Does this need a dependency on SUNWpenr to ? I add the dependency. > > 5. usr/src/pkgdefs/SUNWpenr/depend > You need to check this, as I don't think root packages > normally depend on the 'user' package ? I can see why > you have it but I think it may have problems when > the user pkg bits are installed on a remote server. > Yes, 'user' package should depends on 'root' packages. The revised webrev is at, http://cr.opensolaris.org/~mishuang/pen/ Thanks, Chris
