Hi Chris,
Christopher Mi said the following on Tuesday 03 March 2009 02:50 PM:
> Hi Srirama,
>
> Thanks for your review, please see my replies below.
>
> Srirama Sharma wrote:
>> Hi Chris,
>>
>> Below are few comments:
>>
>> 2. In usr/src/cmd/pen/Solaris/pen-wrapper,
>> - In line 1, replace "#!/sbin/sh" with "#!/usr/bin/ksh93"
>> - Change
>> 36 . /lib/svc/share/smf_include.sh
>> to
>> 36 source /lib/svc/share/smf_include.sh
>> - At the last line, you could probably replace "exit 0" with
>> "exit $SMF_EXIT_OK"
> I only accept the last one. Because I found most of the files in
> /lib/svc/method use '/sbin/sh' and '.'
It is okay with me.
>> - Please check if there are any missing dependencies by running
>> the check-deps.pl script or by doing "make check_deps" in
>> usr/src/pkgdefs/SUNWpen
> I get an error message
> error: SFW_PKGDB must be set
> using "make check_deps" in usr/src/pkgdefs/SUNWpen. Any ideas?
You would need to set this in sfw-developer.sh file by uncommenting the
lines at the bottom where SFW_PKGDB is pointing to latest packages of
snv. Then use the same sfw-developer.sh file to set up the bldenv.
Also, along with above changes you could set SFW_RUN_CHECK_DEPS variable
to nothing by uncommenting the below line in sfw-developer.sh so that
the dependency check is done by default when you run a nightly.
#SFW_RUN_CHECK_DEPS=; export SFW_RUN_CHECK_DEPS
>
> The revised webrev is at,
> http://cr.opensolaris.org/~mishuang/pen/
The revised webrev looks good to me.
Curious to know what kind of dependency does pen have on nis ( I see in
the manifest file that there is a dependency on nis client service) ?
Thanks,
Srirama
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://mail.opensolaris.org/pipermail/sfwnv-discuss/attachments/20090303/d0babb4f/attachment.html>
