Christopher, This mainly looks good to me, see below foe a few comments ...
Paul Christopher Mi wrote: > > Please help to review pen, a load balancer for "simple" tcp based > protocols. > > The home page is at, > http://siag.nu/pen/ > > The webrev is at, > http://cr.opensolaris.org/~mishuang/pen/ 1. usr/src/cmd/pen/METADATA Please check the SRC: ftp link is correct because it did not work when I tried it (server may have been down though). 2. usr/src/cmd/pen/Makefile.sfw Lines 44-46, do you need to use the protofix here because you only seem to be installing stuff in using install-sfw with _install so the permissions should be correct ? 3.usr/src/pkgdefs/SUNWpen/Makefile You have your own depend file, so delete .. 31 DATAFILES = depend 4. usr/src/pkgdefs/SUNWpen/depend Does this need a dependency on SUNWpenr to ? 5. usr/src/pkgdefs/SUNWpenr/depend You need to check this, as I don't think root packages normally depend on the 'user' package ? I can see why you have it but I think it may have problems when the user pkg bits are installed on a remote server. -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
