Hi Srirama and Paul,
Thanks for your information about the package dependency checking.
I think most people in this alias can benefit from it also.
$ make check_deps
[ -d /export/home/sm207740/pen/packages/i386/nightly-nd ] || mkdir -p
/export/home/sm207740/pen/packages/i386/nightly-nd
/usr/bin/rm -f pkginfo; nawk -f ../awk_pkginfo pkginfo.tmpl > pkginfo
../audit_pkg SUNWpen
pkgmk -f prototype_i386 -d
/export/home/sm207740/pen/packages/i386/nightly-nd -r
/export/home/sm207740/pen/proto/root_i386 \
-p "ironknife20090304110956" \
-o SUNWpen
## Building pkgmap from package prototype file.
## Processing pkginfo file.
## Attempting to volumize 23 entries in pkgmap.
part 1 -- 466 blocks, 95 entries
## Packaging one part.
/export/home/sm207740/pen/packages/i386/nightly-nd/SUNWpen/pkgmap
/export/home/sm207740/pen/packages/i386/nightly-nd/SUNWpen/pkginfo
/export/home/sm207740/pen/packages/i386/nightly-nd/SUNWpen/install/copyright
/export/home/sm207740/pen/packages/i386/nightly-nd/SUNWpen/install/depend
/export/home/sm207740/pen/packages/i386/nightly-nd/SUNWpen/reloc/usr/bin/mergelogs
/export/home/sm207740/pen/packages/i386/nightly-nd/SUNWpen/reloc/usr/bin/pen
/export/home/sm207740/pen/packages/i386/nightly-nd/SUNWpen/reloc/usr/bin/penctl
/export/home/sm207740/pen/packages/i386/nightly-nd/SUNWpen/reloc/usr/bin/penlog
/export/home/sm207740/pen/packages/i386/nightly-nd/SUNWpen/reloc/usr/bin/penlogd
/export/home/sm207740/pen/packages/i386/nightly-nd/SUNWpen/reloc/usr/share/doc/pen/AUTHORS
/export/home/sm207740/pen/packages/i386/nightly-nd/SUNWpen/reloc/usr/share/doc/pen/COPYING
/export/home/sm207740/pen/packages/i386/nightly-nd/SUNWpen/reloc/usr/share/doc/pen/ChangeLog
/export/home/sm207740/pen/packages/i386/nightly-nd/SUNWpen/reloc/usr/share/doc/pen/HOWTO
/export/home/sm207740/pen/packages/i386/nightly-nd/SUNWpen/reloc/usr/share/doc/pen/README
/export/home/sm207740/pen/packages/i386/nightly-nd/SUNWpen/reloc/usr/share/doc/pen/penstats
/export/home/sm207740/pen/packages/i386/nightly-nd/SUNWpen/reloc/usr/share/man/man1/mergelogs.1
/export/home/sm207740/pen/packages/i386/nightly-nd/SUNWpen/reloc/usr/share/man/man1/pen.1
/export/home/sm207740/pen/packages/i386/nightly-nd/SUNWpen/reloc/usr/share/man/man1/penctl.1
/export/home/sm207740/pen/packages/i386/nightly-nd/SUNWpen/reloc/usr/share/man/man1/penlog.1
/export/home/sm207740/pen/packages/i386/nightly-nd/SUNWpen/reloc/usr/share/man/man1/penlogd.1
## Validating control scripts.
## Packaging complete.
/usr/perl5/bin/perl
/export/home/sm207740/pen/usr/src/tools/check-deps.pl -e
/export/home/sm207740/pen/usr/src/tools/exception_list.check-deps -d
/export/home/sm207740/pen/packages/i386/nightly-nd -p
/net/netinstall.sfbay/export/nv/x/latest/Solaris_11/Product SUNWpen
There is no error or warning messages. So I consider it as a success.
Srirama Sharma wrote:
> Hi Chris,
>
>
> Christopher Mi said the following on Tuesday 03 March 2009 02:50 PM:
>> Hi Srirama,
>>
>> Thanks for your review, please see my replies below.
>>
>> Srirama Sharma wrote:
>>> Hi Chris,
>>>
>>> Below are few comments:
>>>
>>> 2. In usr/src/cmd/pen/Solaris/pen-wrapper,
>>> - In line 1, replace "#!/sbin/sh" with "#!/usr/bin/ksh93"
>>> - Change
>>> 36 . /lib/svc/share/smf_include.sh
>>> to
>>> 36 source /lib/svc/share/smf_include.sh
>>> - At the last line, you could probably replace "exit 0" with
>>> "exit $SMF_EXIT_OK"
>> I only accept the last one. Because I found most of the files in
>> /lib/svc/method use '/sbin/sh' and '.'
> It is okay with me.
>
>>> - Please check if there are any missing dependencies by
>>> running the check-deps.pl script or by doing "make check_deps" in
>>> usr/src/pkgdefs/SUNWpen
>> I get an error message
>> error: SFW_PKGDB must be set
>> using "make check_deps" in usr/src/pkgdefs/SUNWpen. Any ideas?
>
> You would need to set this in sfw-developer.sh file by uncommenting
> the lines at the bottom where SFW_PKGDB is pointing to latest packages
> of snv. Then use the same sfw-developer.sh file to set up the bldenv.
>
> Also, along with above changes you could set SFW_RUN_CHECK_DEPS
> variable to nothing by uncommenting the below line in
> sfw-developer.sh so that the dependency check is done by default when
> you run a nightly.
>
> #SFW_RUN_CHECK_DEPS=; export SFW_RUN_CHECK_DEPS
>
>>
>> The revised webrev is at,
>> http://cr.opensolaris.org/~mishuang/pen/
>
> The revised webrev looks good to me.
>
> Curious to know what kind of dependency does pen have on nis ( I see
> in the manifest file that there is a dependency on nis client service) ?
Srirama,
I think nis/client is indeed inappropriate, how about
svc:/milestone/multi-user:default or
svc:/milestone/multi-user-server:default?
Thanks,
Chris
>
> Thanks,
> Srirama
