Angela, See below for the comments from my quick skip through ...
Paul :-) angela wrote: > > I am porting "xmlrpc-c", programming libraries and related tools to help user > write an XML-RPC server or client in C or C++. > > Can you please have a review on my code. The webrev is at: > http://cr.opensolaris.org/~angelali/xmlrpc-c/ 1. usr/src/lib/libxmlrpc-c/METADATA Add contents of the "BUGTRAQ:" field Miss a ':' after NAME Make the NAME: field more descriptive 2. usr/src/lib/libxmlrpc-c/Makefile.sfw Add after ./configure (twice) the default options, eg. .. ./configure $(CONFIGURE_OPTIONS) so it explicitly defines the prefix, etc. 3. usr/src/lib/libxmlrpc-c/curlbuild.h Where is this used? I can't see where it is used, if it is not used delete it. 4. usr/src/lib/libxmlrpc-c/install-sfw & usr/src/lib/libxmlrpc-c/install-sfw-64 Change as follows ... Roland Mainz wrote: > use /usr/bin/ksh93 or /usr/bin/bash for install-sfw* > and > replace ". ${SRC}/tools/install.subr" with > "source ${SRC}/tools/install.subr" (the idea is to > catch failures in the script and abort it at that point, > right now the script will just continue) 5. usr/src/lib/libxmlrpc-c/install-sfw & usr/src/lib/libxmlrpc-c/install-sfw-64 Remove the write permission bit on files installed into /usr (they are okay in the prototype_* file though). 6. usr/src/pkgdefs/SUNWlibxmlrpc-c/depend The Copyright year is wrong Have you checked the dependencies using the gate's dependency checker script? 7. usr/src/pkgdefs/SUNWlibxmlrpc-c/pkginfo.tmpl Add the packages version at the end of the DESC= line, eg .. DESC="............. (1.06.31)" -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
