Hi Angela,
angela said the following on Monday 09 March 2009 12:01 PM: > Thanks Paul for review. > The new webrev is generated: > http://cr.opensolaris.org/~angelali/xmlrpc-c/ > > Paul Cunningham ??: >> Angela, >> >> 3. usr/src/lib/libxmlrpc-c/curlbuild.h >> Where is this used? I can't see where it is used, if it >> is not used delete it. > This header file will be included by source code if build server is > less that snv_109. See Makefile.sfw and curl.fix. > For build server less that snv_109, there is a bug in this header file > that will lead 64-bit compile failure. > The header file curlbuild.h is got from snv_109, with the fix of upper > bug. > In curl.fix, if the build server is less than snv_109, the script will > copy this header file to source so that the source will include this > header file. The fix for curl bug CR6770465 has already been integrated in to the sfw-gate. So you should be using the "curlbuild.h" file from the proto area instead of checking in a separate copy of it. (Am currently going through the new webrev. Will be sending out few more comments) Thanks, Srirama
