Paul Cunningham ??: > Looks okay to me, but see below ... > > Paul > > angela wrote: >> >> The new webrev is generated: >> http://cr.opensolaris.org/~angelali/xmlrpc-c/ >> >> Paul Cunningham wrote: > ... cut .. >>> angela wrote: >>>> >>>> I am porting "xmlrpc-c", programming libraries and related tools to >>>> help user write an XML-RPC server or client in C or C++. > > ... cut ... > >>> 3. usr/src/lib/libxmlrpc-c/curlbuild.h >>> Where is this used? I can't see where it is used, if it >>> is not used delete it. >> This header file will be included by source code if build server is >> less that snv_109. See Makefile.sfw and curl.fix. >> For build server less that snv_109, there is a bug in this header >> file that will lead 64-bit compile failure. >> The header file curlbuild.h is got from snv_109, with the fix of >> upper bug. >> In curl.fix, if the build server is less than snv_109, the script >> will copy this header file to source so that the source will include >> this header file. > I assume you will take on Srirama Sharma <Srirama.Sharma at Sun.COM> > comment. Yes, I will. > > ... cut ... > >>> 7. usr/src/pkgdefs/SUNWlibxmlrpc-c/pkginfo.tmpl >>> Add the packages version at the end of the DESC= line, eg .. >>> DESC="............. (1.06.31)" >> Done > It's more normal to put it at the end of the DESC= line (ie. before > the end quote, as above) Thanks, will modify as you mentioned.
Will modify and generate webrev with modification according to Srirama's review. Thanks again, Angela
