Thanks Paul for review. The new webrev is generated: http://cr.opensolaris.org/~angelali/xmlrpc-c/
Paul Cunningham ??: > Angela, > > See below for the comments from my quick skip through ... > > Paul :-) > > > angela wrote: >> >> I am porting "xmlrpc-c", programming libraries and related tools to >> help user write an XML-RPC server or client in C or C++. >> >> Can you please have a review on my code. The webrev is at: >> http://cr.opensolaris.org/~angelali/xmlrpc-c/ > > 1. usr/src/lib/libxmlrpc-c/METADATA > Add contents of the "BUGTRAQ:" field Added: BUGTRAQ: solaris/library/xmlrpc-c And I'm on process of applying create bug category. > > Miss a ':' after NAME > > Make the NAME: field more descriptive Ok. see below: NAME: XMLRPC C/C++ Library, lightweight RPC library based on XML and HTTP > > 2. usr/src/lib/libxmlrpc-c/Makefile.sfw > Add after ./configure (twice) the default options, eg. .. > ./configure $(CONFIGURE_OPTIONS) > so it explicitly defines the prefix, etc. Done. > > 3. usr/src/lib/libxmlrpc-c/curlbuild.h > Where is this used? I can't see where it is used, if it > is not used delete it. This header file will be included by source code if build server is less that snv_109. See Makefile.sfw and curl.fix. For build server less that snv_109, there is a bug in this header file that will lead 64-bit compile failure. The header file curlbuild.h is got from snv_109, with the fix of upper bug. In curl.fix, if the build server is less than snv_109, the script will copy this header file to source so that the source will include this header file. > > 4. usr/src/lib/libxmlrpc-c/install-sfw > & usr/src/lib/libxmlrpc-c/install-sfw-64 > Change as follows ... > Roland Mainz wrote: > > use /usr/bin/ksh93 or /usr/bin/bash for install-sfw* > > and > > replace ". ${SRC}/tools/install.subr" with > > "source ${SRC}/tools/install.subr" (the idea is to > > catch failures in the script and abort it at that point, > > right now the script will just continue) Done > > 5. usr/src/lib/libxmlrpc-c/install-sfw > & usr/src/lib/libxmlrpc-c/install-sfw-64 > Remove the write permission bit on files installed > into /usr (they are okay in the prototype_* file though). Done > > 6. usr/src/pkgdefs/SUNWlibxmlrpc-c/depend > The Copyright year is wrong Done > > Have you checked the dependencies using the gate's > dependency checker script? Yes, I used the script to check, but nothing output. See the following for pkg check output: $ make check_deps /usr/bin/rm -f pkginfo; nawk -f ../awk_pkginfo pkginfo.tmpl > pkginfo ../audit_pkg SUNWlibxmlrpc-c pkgmk -f prototype_i386 -d /export/home2/hl150050/sfwnv/packages/i386/nightly-nd -r /export/home2/hl150050/sfwnv/proto/root_i386 \ -p "copperwaist20090306175336" \ -o SUNWlibxmlrpc-c ## Building pkgmap from package prototype file. ## Processing pkginfo file. ## Attempting to volumize 93 entries in pkgmap. part 1 -- 2432 blocks, 333 entries ## Packaging one part. ... ## Validating control scripts. ## Packaging complete. /usr/perl5/bin/perl /export/home2/hl150050/sfwnv/usr/src/tools/check-deps.pl -e /export/home2/hl150050/sfwnv/usr/src/tools/exception_list.check-deps -d /export/home2/hl150050/sfwnv/packages/i386/nightly-nd -p /net/bounty.prc/export/nv/x/latest/Solaris_11/Product SUNWlibxmlrpc-c $ The packages additional to defaults are what I got from: 1) got libraries they depend 2) got pkg name for these libraries. > > 7. usr/src/pkgdefs/SUNWlibxmlrpc-c/pkginfo.tmpl > Add the packages version at the end of the DESC= line, eg .. > DESC="............. (1.06.31)" Done
