Jason, See below for my comments ....
Paul Jason Zhao wrote: > > Can someone do a review for the webrev of RFE (6811043 Need to port > snort into Solaris), please. > > Bug: > http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6811043 > > Webrev: > http://cr.opensolaris.org/~jxzhao/snort ==== Start of Comments === 1. usr/src/cmd/Makefile & usr/src/pkgdefs/Makefile You need to resync this with the sfwnv gate otherwise it looks as though you are try to delete other stuff. 2. usr/src/cmd/snort/METADATA Make the NAME: field more descriptive Change ... 7 SRC: to be the url of the src tarball, ...../snort-2.8.3.1.tar.gz 3. usr/src/cmd/snort/Makefile.sfw Use the predefined configure prefix value CFGPREFIX from the Makefile.master - your definition is wrong anyway as '--prefix=$(ROOT)/usr' says at user runtime it will be running from the workspace's proto area rather than /usr. So change as follows ... Delete lines ... 45 CONFIGURE_OPTIONS += --prefix=$(ROOT)/usr 41 CONFIGURE_OPTIONS = --mandir=/tmp then you will get the '--prefix=' and '--mandir=' from Makefile.master Your lines ... 49 CONFIGURE_OPTIONS64 += --bindir=$(ROOT)/usr/bin/$(MACH64) 50 CONFIGURE_OPTIONS64 += --exec_prefix=$(ROOT)/usr/lib/$(MACH64) I think should also be ... 49 CONFIGURE_OPTIONS64 += --bindir=$(CFGUSRSBIN64) 50 CONFIGURE_OPTIONS64 += --exec_prefix=/usr/lib/$(MACH64) You are building this with 'gcc' will it build with the Sun compiler (may need patches) ? If it will use the Sun compiler. In install32: & install64:, after running 'make install' do you need to run 'protofix' to correct any file permissions/owner/group settings? (see (6)). 4. usr/src/cmd/snort/sunman-stability Is your 22 Interface Stability Volatile correct? 5. usr/src/pkgdefs/SUNWsnort/pkginfo.tmpl Add the pkg version number to the end of the DESC= line, eg. DESC=".................. (2.8.3.1)" 6. usr/src/pkgdefs/SUNWsnort/prototype_com & usr/src/pkgdefs/SUNWsnort/prototype_i386 & usr/src/pkgdefs/SUNWsnort/prototype_sparc Do not install files in /usr with the write permission bit set. ==== End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
