Hi Jason, The updated webrev looks fine.
Regards Muktha Jason Zhao wrote: > Hi, > > Thanks for Muktha and Paul's help, and I have finished modification > for snort according to their comments, please review it the newer > version again. > > The webrev is still: > http://cr.opensolaris.org/~jxzhao/snort > > <Note>: The compiler for snort is still gcc, I tried to fix the issue > in Sun Studio 12 compiler but could not work sofar. There are some > modifications related and I could not work it out. I sent the question > to maintainer of snort utility months ago, and they said they would > fix it in their development release(2.8.4), but when I tried to pull > the latest development revision and they seems have fixed parts of > issues but some still there today. If I modified all code to CC, I am > afraid it might introduce some risks. So I still leave gcc as > compiler. Hope it is not a big defect for this utility. > > Please tell me your comments. > > Thanks > Jason > Jason Zhao wrote: >> Muktha Narayan wrote: >>> Hi Jason, >>> >>> Jason Zhao wrote: >>>>> 2. Makefile.sfw >>>>> It is recommended to use Sun Studio 12 compilers. Most of the >>>>> components use the same. >>>> Sorry, I am not sure I can follow you, please point out in detail. >>>> Thank you. >>>> >>> What I meant is that it is recommended to build the sources using >>> Sun compilers (CC) instead of gcc. >> I could not build snort with CC. I met with following issue when build. >> --------------------------------------------------------------- >> >> <snip> >> cc -DHAVE_CONFIG_H -I. -I../../.. -I../../.. -I../../../src >> -I../../../src/sfutil -I../../../src/output-plugins >> -I../../../src/detection-plugins -I../../../src/dynamic-plugins >> -I../../../src/preprocessors -I../../../src/preprocessors/flow >> -I../../../src/preprocessors/portscan >> -I../../../src/preprocessors/flow/int-snort >> -I../../../src/preprocessors/HttpInspect/include >> -I../../../src/preprocessors/Stream5 -I../../../src/target-based >> -DBSD_COMP -D_REENTRANT -I/usr/include/pcre -g -DDYNAMIC_PLUGIN >> -DDETECTION_OPTION_TREE -c snort_stream5_tcp.c >> "../../../src/rules.h", line 53: warning: macro redefined: INADDR_NONE >> "snort_stream5_tcp.c", line 2528: reference to static identifier >> "Stream5SeglistDeleteNode" in extern inline function >> "snort_stream5_tcp.c", line 3068: reference to static identifier >> "FlushStream" in extern inline function >> "snort_stream5_tcp.c", line 3080: reference to static identifier >> "DeleteSeglist" in extern inline function >> cc: acomp failed for snort_stream5_tcp.c >> *** Error code 2 >> make: Fatal error: Command failed for target `snort_stream5_tcp.o' >> Current working directory >> /export/home/Jason/work/pkgport/snort-2.8.3.1/src/preprocessors/Stream5 >> *** Error code 1 >> </snip> >> >> ---------------------------------------------------------------- >> I have sent to development mail list of snort about the issue, I >> think the >> maintainer of snort has accepted and will put it on their schedule. >> >> I did not try to fix the issue by myself and I will try. >> >>>>> o you seem to be installing snort.8 into '/usr/share/man/man1' dir >>>>> as snort.1. Is this intended? I guess it should be placed in >>>>> either '/usr/share/man/man1m' or '/usr/share/man/man8' dir. Please >>>>> check. >>>> Yes, because I was called that man8 is not used for Solaris, so I >>>> moved the manual to man1. >>>> >>>> If you are sure the "man8" is still available for Solaris, I will >>>> copy the manual to "man8". Thanks. >>> snort.8 needs to be installed into '/usr/share/man/man1m'. Please >>> refer the below link: >>> http://developers.sun.com/solaris/articles/man_pages.html >> Thank you for your help! >> >> Thanks >> Jason >> _______________________________________________ >> sfwnv-discuss mailing list >> sfwnv-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss >
