Paul Cunningham wrote: > > > Jason Zhao wrote: >> >> Thanks for Muktha and Paul's help, and I have finished modification >> for snort according to their comments, please review it the newer >> version again. >> >> The webrev is still: >> http://cr.opensolaris.org/~jxzhao/snort >> >> <Note>: The compiler for snort is still gcc, I tried to fix the issue >> in Sun Studio 12 compiler but could not work sofar. There are some >> modifications related and I could not work it out. I sent the >> question to maintainer of snort utility months ago, and they said >> they would fix it in their development release(2.8.4), but when I >> tried to pull the latest development revision and they seems have >> fixed parts of issues but some still there today. If I modified all >> code to CC, I am afraid it might introduce some risks. So I still >> leave gcc as compiler. Hope it is not a big defect for this utility. >> >> Please tell me your comments. > > I have another very minor comment, everything else looks okay ... > > usr/src/cmd/snort/METADATA > Change the NAME: line to be more descriptive; and you don't need the > version number on it Thank you, Paul. Does that change looks OK with following line? ---------------------------------------------------------------- NAME: snort .... ----------------------------------------------------------------
Thanks Jason
