Hi Jason,
Below are few comments:
1. usr/src/cmd/Makefile
Please add the entry in alphabetical order.
2. Makefile.sfw
It is recommended to use Sun Studio 12 compilers. Most of the
components use the same.
3. METADATA
In http://www.snort.org/got_source/source.html, I see that 2.8.3.2
is available. Would it be possible to use the same?
4. install-sfw
o It is recommended to use /usr/bin/ksh93. This allows you to add:
# stop at first error
set -o errexit
And to call "source" instead of "." in this line:
source ${SRC}/tools/install.subr
o you seem to be installing snort.8 into '/usr/share/man/man1' dir as
snort.1. Is this intended? I guess it should be placed in either
'/usr/share/man/man1m' or '/usr/share/man/man8' dir. Please check.
5. sunman-stability
Is Interface Stability 'Volatile' right? I guess it should be
'Uncommitted'
6. usr/src/pkgdefs/Makefile
The entries should be in alphabetical order.
7. pkginfo.tmpl
You may want to Change DESC to
"snort - Network Intrusion and Protection Detector (2.8.3.1)"
Also please check for typo (dectector).
8. prototype_com
o Do the libraries need write permission?
o The directory should have 755 permission.
85 d none usr/share/doc/snort 444 root bin
o The group entry for '/usr/share/man' is 'bin' and not 'root'.
Please check.
d none usr/share/man 755 root root
o The directory should have 755 permission
136 d none usr/share/man/man1 444 root bin
o Is there a specific reason why the source files are being shipped?
o Aren't the below sym links to libsf_engine.so.0.0.0 ?
54 f none usr/lib/snort_dynamicengine/libsf_engine.so 755 root bin
55 f none usr/lib/snort_dynamicengine/libsf_engine.so.0 755 root bin
If so, the entries need to be changed to
s none
usr/lib/snort_dynamicengine/libsf_engine.so=libsf_engine.so.0.0.0
s none
usr/lib/snort_dynamicengine/libsf_engine.so.0=libsf_engine.so.0.0.0
Similarly please check for the other libraries as well.
9. pcap_pkthdr32.h.patch64
As the sys/types32.h header is available on Solaris only, you could
include it under #ifdef (__sun). Also you could retain the timeval32
struct definition in #else part so that the patch can be given upstream.
-struct timeval32
-{
- u_int32_t tv_sec; /* seconds */
- u_int32_t tv_usec; /* microseconds */
-};
Also make sure you resync the workspace so that you do not remove the
recent commits to sfw.
Regards
Muktha
Jason Zhao wrote:
> Hi,
>
> Can someone do a review for the webrev of RFE (6811043 Need to port
> snort into Solaris), please.
>
> Bug:
> -------------------------------------------
> http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6811043
>
> Webrev:
> -------------------------------------------
> http://cr.opensolaris.org/~jxzhao/snort
>
>
> Thanks
> Jason
> _______________________________________________
> sfwnv-discuss mailing list
> sfwnv-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
>
