Hii Muktha, Thanks for your review! Please see my inline comments. Webrev updated at http://cr.opensolaris.org/~yue.li/beanshell/
Thanks, - Claire Muktha Narayan wrote: > Hi Claire, > > Few comments below: > > 1. Makefile.sfw o "pragma ident" keywords is generally not used in > files other than source files. In Makefiles, install scripts and such, > use "ident" (without "pragma"). > > o If you intend to use /usr/sfw/bin/gtar then you could use it with > "-z" option to unzip the tarball instead of doing the same using 2 > commands (/usr/bin/gzip -dc and /usr/sfw/bin/gtar ) Done. > > 2. bsh.1 > > 118 Apaceh/IBM Bean Scripting Framework (BSF) Adapter for BeanShell > Please check typo (Apaceh) Done. > > 3. install-sfw > All the html docs are getting installed in > '/usr/share/lib/java/javadoc/beanshell/javadoc/'. Shouldn't they be > installed in '/usr/share/lib/java/javadoc/beanshell/' directory itself? Done. Move all html docs into /usr/share/lib/java/javadoc/beanshell/ > > Regards > Muktha > > Claire Li wrote: >> Hi Paul and the team, >> >> I've updated the webrev according to the comment. Please review: >> http://cr.opensolaris.org/~claireli/ >> >> Thanks, >> Claire >> >> >> Paul Cunningham wrote: >>> Resent - it should have read as ... >>> >>> Note, I haven't reviewed this, but you need to update the METADATA as >>> per ... >>> "http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines"; >>> and also in Makefile,sfw extract the BEANSHELL= info from the METADATA. >>> >>> Please update and resend out the webrev link >>> >>> Paul >>> >>> Claire Li wrote: >>>> Hi team, >>>> >>>> I am porting beanshell v2.0b4 into OpenSolaris. Beanshell is a >>>> small and embeddable Java source interpreter. >>>> >>>> Would you please take a review on my code? The webrev is at: >>>> http://cr.opensolaris.org/~claireli/beanshell/ >>> >> >> _______________________________________________ >> sfwnv-discuss mailing list >> sfwnv-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss >
