Hi Muktha, Please take a review of my code. Paul has approved it. I need one more approve to move on. http://cr.opensolaris.org/~yue.li/beanshell/
Thanks, Claire Claire Li wrote: > Hi Paul and Muktha, > > I've withdrawn the two zip files from delivering them. Please take a > review. > Webrev updated at http://cr.opensolaris.org/~yue.li/beanshell/ > > Thanks, > Claire > > > Paul Cunningham wrote: >> >> >> Claire Li wrote: >>> >>> Please see my comments below. >>>>>> Why are you delivering the source file ? ... >>>>>> 70 _install N bsh-2.0b4-src.zip ${SRCDIR}/bsh-20.b4-src.zip 444 >>>>>> Do you need to deliver the two .zip files? >>>>>> >>>>> Done. >>>>> That is a typo. "bsh-20.b4-src.zip" should be "bsh-2.0b4-src.zip". >>>> >>>> I'm still not sure why you are delivering this source zip file though >>>> 70 f none usr/share/lib/java/src/bsh-2.0b4-src.zip 0444 root bin >>>> >>>> or the other .zip file (bsh-2.0b4-javadoc.zip) >>>> >>>> so why? >>> I agree with that bsh-2.0b4-javadoc.zip is not necessary to deliver >>> since all >>> the html files are delivered in /usr/share/lib/java/javadoc/beanshell. >>> >>> As for the source file bsh-2.0b4-src.zip, is there any >>> rules/principles about >>> what kind of source files should be delivered and what kind should not? >> >> Sorry I don't know what the current rules are on src delivery, but it >> used to be that if your need to delivery it (ie. test or example >> code) it it should go in a separate SUNW package (so users don't have >> to install unwanted stuff). Check with someone like Norm Jacobs. >> >> Paul > > _______________________________________________ > sfwnv-discuss mailing list > sfwnv-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
