Paul,

Thanks for the review.
I've updated the CDDL in SUNWbeanshell/pkginfo.tmpl .
Webrev updated at http://cr.opensolaris.org/~yue.li/beanshell/

Thanks,
Claire

Paul Cunningham wrote:
>
>
> Claire Li wrote:
>
>>> 4. CDDL HEADER and top of files (various files)
>>>    Cosmetic: You need to update the top of various files
>>>    so that they conform to ...
>>> "http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/"; 
>>
>>
>> Would you tell me which files should be modified?
>> I can not see the differences between mine and the prototype.
>
> They all seem to look okay now (maybe I had reviewers blindness 
> previously - unless you changed one/some), the only one you may want 
> to change is SUNWbeanshell/pkginfo.tmpl (to add a missing empty # line 
> ...
>
>   18 #
>   19 # CDDL HEADER END
>      #
>   20
>   21 #
>   22 # Copyright 2009 Sun Microsystems, Inc.  All rights reserved.
>
> I'll recheck the other stuff later


Reply via email to