Claire,

This looks good to me, but see below ...

Claire Li wrote:
> 
> Webrev updated at: http://cr.opensolaris.org/~yue.li/beanshell/

>>>> Claire Li wrote:
>>>>> I am porting beanshell v2.0b4 into OpenSolaris. Beanshell is a 
>>>>> small and embeddable Java source interpreter.

   ... cut ..

>> 2. usr/src/cmd/beanshell/install-sfw
   ... cut ...
>>    Why are you delivering the source file ? ...
>>     70 _install N bsh-2.0b4-src.zip ${SRCDIR}/bsh-20.b4-src.zip 444
>>    Do you need to deliver the two .zip files?
>>
> Done.
> That is a typo. "bsh-20.b4-src.zip" should be "bsh-2.0b4-src.zip".

I'm still not sure why you are delivering this source zip file though
   70 f none usr/share/lib/java/src/bsh-2.0b4-src.zip  0444 root bin

or the other .zip file (bsh-2.0b4-javadoc.zip)

so why?
-- 
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Business Unit

Reply via email to