Paul, Thanks for your detailed review! Please see my inline comments. Webrev updated at: http://cr.opensolaris.org/~yue.li/beanshell/
Thanks! Claire Paul Cunningham wrote: > Claire, > > See my comments below ... > > Paul > > Claire Li wrote: >> >> I've updated the webrev according to the comment. Please review: >> http://cr.opensolaris.org/~claireli/ > >> >> Paul Cunningham wrote: >>> Claire Li wrote: >>>> >>>> I am porting beanshell v2.0b4 into OpenSolaris. Beanshell is a >>>> small and embeddable Java source interpreter. > > ==== Start of Comments === > > 1. usr/src/cmd/beanshell/METADATA > The SRC: line should be the url to the source tarball > on an opensource website, eg ...../beanshell-2.0b4.tar.gz > Done. > 2. usr/src/cmd/beanshell/install-sfw > On line ... > 67 cd ${TOP}/beanshell-2.0b4/dist > pass in the beanshell-2.0b4 from the Makefile.sfw (as > extracted from the METADATA). > Done. > Why are you delivering the source file ? ... > 70 _install N bsh-2.0b4-src.zip ${SRCDIR}/bsh-20.b4-src.zip 444 > Do you need to deliver the two .zip files? > Done. That is a typo. "bsh-20.b4-src.zip" should be "bsh-2.0b4-src.zip". > 3. usr/src/cmd/beanshell/sunman/bsh.1 > Is this correct ? ... > 140 Interface Stability Volatile > Done. Volatile -> Uncommitted > 4. CDDL HEADER and top of files (various files) > Cosmetic: You need to update the top of various files > so that they conform to ... > "http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/"; > > Would you tell me which files should be modified? I can not see the differences between mine and the prototype. > 5. usr/src/pkgdefs/SUNWbeanshell/copyright > You might need to add src owner copyright lines at the > top, ie. those extracted from the src files in the unpacked > tarball > Done. > 6. usr/src/pkgdefs/SUNWbeanshell/pkginfo.tmpl > On the DESC= line put the version number in brackets, eg. .. > DESC="....... (2.0b4)" > Done. > 7. usr/src/pkgdefs/SUNWbeanshell/prototype_i386 > & usr/src/pkgdefs/SUNWbeanshell/prototype_sparc > Cosmetic: add the SUNW pkg name in comment as done in .. > "http://src.opensolaris.org/source/xref/sfw/usr/src/pkgdefs/SUNWmeld/prototype_i386"; > > > Done. > 8. usr/src/pkgdefs/SUNWbeanshell/prototype_sparc > Line ... > 45 # List files which are I386 specific here > I386 ??? > Done. I386 -> SPARC > ==== End of Comments =====
