Spoorthy, Some more comments below ..
Spoorthy H.S wrote: > > New webrev is at http://cr.opensolaris.org/~spoorthy/conmanupd1/ > and comments inline.. 1. usr/src/cmd/Makefile You need to resync this with the gate so it doesn't look as though you are changing other stuff. 2. usr/src/pkgdefs/Makefile Move your added bits up so they are alphabetical, ie. before SUNWconvmv instead of after. 3. usr/src/cmd/conman/Makefile.sfw Cosmetic: add line space after line 20 so layout conforms. 4. usr/src/cmd/conman/install-sfw Cosmetic: move line .. 32 cd ${PKGVERS} down to after line 46, so it becomes something like (so its easier to see) ... 45 source ${SRC}/tools/install.subr 46 .. cd ${PKGVERS} .. 47 # install conman man page 48 49 _install M man/conman.1 ${MAN1}/conman.1 444 5. usr/src/pkgdefs/SUNWconmanr/Makefile & usr/src/pkgdefs/SUNWconmanr/prototype_com & usr/src/pkgdefs/SUNWconmanu/prototype_com Cosmetic: add missing # line at top so it conforms, eg. .. # 1 # CDDL HEADER START 2 # 3 # The contents of this file are subject to the terms of the 6. usr/src/pkgdefs/SUNWconmanr/pkginfo.tmpl & usr/src/pkgdefs/SUNWconmanu/pkginfo.tmpl Cosmetic: top of file still doesn't conform to that in .. "http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/"; 7. usr/src/pkgdefs/SUNWconmanu/copyright I assume you will be adding the src owner copyright lines? 8. usr/src/pkgdefs/SUNWconmanu/prototype_com I think you need to add a line for ... d none usr/share ..... END -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
