Thanks Paul. -Spoorthy
Cunningham, Paul wrote: > looks okay > > paul > > >> -----Original Message----- >> From: Spoorthy.Shankarmurthy at Sun.COM >> [mailto:Spoorthy.Shankarmurthy at Sun.COM] >> Sent: 30 March 2009 10:27 >> To: Cunningham, Paul >> Cc: SFW-NV Discuss; Fritz Ferstl >> Subject: Re: [sfwnv-discuss] Code review request for conman >> >> Yeah. Changed the line in prototype_com file. >> Here's the new webrev. >> http://cr.opensolaris.org/~spoorthy/conmanupd5/ >> >> Thanks >> Spoorthy >> >> Cunningham, Paul wrote: >> >>> Very quick look .... >>> >>> >>> >>>> -----Original Message----- >>>> From: Spoorthy Shankarmurthy >>>> >> [mailto:Spoorthy.Shankarmurthy at Sun.COM] >> >>>> Sent: 27 March 2009 17:43 >>>> To: Cunningham, Paul >>>> Cc: SFW-NV Discuss; ferstl at Sun.COM >>>> Subject: Re: [sfwnv-discuss] Code review request for conman >>>> >>>> Hi Paul, >>>> >>>> I've added the line >>>> 81 d none usr/share 0755 root bin >>>> >>>> >>> I think that should be 'root sys' >>> >>> >>> Also, where are your changes in usr/src/cmd/Makefile and >>> >> why have you >> >>> changed usr/src/Makefile ? >>> >>> paul >>> >>> >>> >>>> in prototype_com file. The new webrev is at >>>> http://cr.opensolaris.org/~spoorthy/conmanupd3/ >>>> Let me know if any review comments other than adding >>>> <bugid><synopsis>. I am still waiting for the reply to add the bug >>>> category to /solaris/utility/<pkgname>. >>>> >>>> >>>> >>>> Thanks >>>> Spoorthy >>>> >>>> ----- Original Message ----- >>>> From: Paul Cunningham <paul.cunningham at tadpole.com> >>>> Date: Thursday, March 26, 2009 4:56 pm >>>> Subject: Re: [sfwnv-discuss] Code review request for conman >>>> To: "Spoorthy H.S" <Spoorthy.Shankarmurthy at Sun.COM> >>>> Cc: SFW-NV Discuss <sfwnv-discuss at opensolaris.org> >>>> >>>> >>>> >>>>> Spoorthy H.S wrote: >>>>> >>>>> >>>>>> The updated webrev is at >>>>>> >>>>>> >>>>> http://cr.opensolaris.org/~spoorthy/conmanupd2/>Please review it. >>>>> >>>>> >>>>>> Note: I have not added the comments for files in webrev >>>>>> >> as <bugid> >> >>>>>> >>>>>> >>>>> < synopsis> since I have not got approval from Valerie Bubb and >>>>> Scott Rotando to add bug category in >>>>> >> /solaris/utitlity/<pkgname. I >> >>>>> will add comments in that form once I get approval from them. >>>>> >>>>> >>>>>> Comments inline ... >>>>>> >>>>>> >>>>> From my quick skip through this looks okay to me except >>>>> >> you missed >> >>>>> this (I think) .. >>>>> >>>>> >>>>> >>>>>> 8. usr/src/pkgdefs/SUNWconmanu/prototype_com >>>>>> I think you need to add a line for ... >>>>>> d none usr/share ..... >>>>>> >>>>>> >>>>> paul >>>>> -- >>>>> >>>>> >> -------------------------------------------------------------------- >> >>>>> -- >>>>> Paul Cunningham >>>>> Software Engineer >>>>> Tadpole Business Unit >>>>> >>>>> >>>>> >>>>>
