Hi Paul, I've added the line 81 d none usr/share 0755 root bin in prototype_com file. The new webrev is at http://cr.opensolaris.org/~spoorthy/conmanupd3/ Let me know if any review comments other than adding <bugid><synopsis>. I am still waiting for the reply to add the bug category to /solaris/utility/<pkgname>.
Thanks Spoorthy ----- Original Message ----- From: Paul Cunningham <[email protected]> Date: Thursday, March 26, 2009 4:56 pm Subject: Re: [sfwnv-discuss] Code review request for conman To: "Spoorthy H.S" <Spoorthy.Shankarmurthy at Sun.COM> Cc: SFW-NV Discuss <sfwnv-discuss at opensolaris.org> > > > Spoorthy H.S wrote: > > > >The updated webrev is at > http://cr.opensolaris.org/~spoorthy/conmanupd2/>Please review it. > >Note: I have not added the comments for files in webrev as <bugid> > < synopsis> since I have not got approval from Valerie Bubb and > Scott Rotando to add bug category in /solaris/utitlity/<pkgname. I > will add comments in that form once I get approval from them. > >Comments inline ... > > From my quick skip through this looks okay to me except you missed > this (I think) .. > > > 8. usr/src/pkgdefs/SUNWconmanu/prototype_com > > I think you need to add a line for ... > > d none usr/share ..... > > paul > -- > -------------------------------------------------------------------- > -- > Paul Cunningham > Software Engineer > Tadpole Business Unit > >
