Looks good to me, just a couple of minor comments below ...

Paul

Simon Sun wrote:
> Per ARC's request, sunman-stability file has been updated to recommend 
> libsip in Note section.
> 
> Besides that, METADATA file has been changed to meet the new 
> requirement. All the others are the same as the last round of review.
> 
> Please help review them. Thanks in advance.


> Simon Sun wrote:
>> I'm porting libosip2, a low layer SIP implementation.
>>
>> Please help to code review my modification. The webrev is at:
>> http://cr.opensolaris.org/~dysun/libosip2/

1. usr/src/lib/Makefile
     & usr/src/pkgdefs/Makefile
    Add items alphabetically

2. usr/src/pkgdefs/SUNWlibosip2/copyright
    Do you need line ? ...
       10 The oSIP library implements the Session ...

END
-- 
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Business Unit

Reply via email to