Simon Sun wrote: > Thanks Paul for your thorough review. :-) > > Please check my inline comments below. The updated version is still at > http://cr.opensolaris.org/~dysun/libosip2/
> > Paul Cunningham wrote: >> 1. usr/src/lib/Makefile >> & usr/src/pkgdefs/Makefile >> Add items alphabetically > Done. I'd intended to do so and it's obviously I failed. :-) >> >> 2. usr/src/pkgdefs/SUNWlibosip2/copyright >> Do you need line ? ... >> 10 The oSIP library implements the Session ... > That comes from author and it's together with the line below > > Copyright (C) 2001,2002,2003,2004,2005,2006,2007 Aymeric MOIZARD > jack at atosc.org > > I'd prefer to leaving it as it is. No change to the file. That's okay with me, but it does look out-of-place in a SUNW pkg 'copyright' file (to me). The other change looks good paul -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
