Christopher, This mainly looks good to me, see below for a few minor comments ...
Paul Christopher Mi wrote: > Hi, > > Please help review this webrev for CR6794702 > PCI Utilities to be included into SFW consolidation. > > http://cr.opensolaris.org/~mishuang/pciutils/ 1. usr/src/cmd/pciutils/install-sfw You could pass the the PKGVERS= info from the Makefile.sfw where it is extracted from the METADATA 2. usr/src/pkgdefs/SUNWpciutils/Makefile Delete the null DATAFILES= line 3. usr/src/pkgdefs/SUNWpciutils/prototype_com Shouldn't these files (f ...) be in the prototype_i386 file? 4. prototype_* Shouldn't there be a prototype_sparc file with an empty list? -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
