Alan Coopersmith wrote:
> Christopher Mi wrote:
>
>> Hi,
>>
>> Please help review this webrev for CR6794702
>> PCI Utilities to be included into SFW consolidation.
>>
>> http://cr.opensolaris.org/~mishuang/pciutils/
>>
>
> - Why i386 only? SPARCs have pci busses too. Are you planning
> to port in the future, or just leave it as found upstream?
>
I extract some code from pciutils-3.0.3/lib/configure. I don't think
pciutils supports SPARC
and I don't plan to port it in the future.
sunos)
case $cpu in
i?86) echo_n " i386-ports"
echo >>$c "#define
PCI_HAVE_PM_INTEL_CONF"
;;
*)
echo " The PCI library
does not support Solaris for this architecture: $cpu"
exit 1
;;
esac
echo >>$c '#define PCI_HAVE_STDINT_H'
;;
> - The .8 man pages need to become .1m man pages on Solaris.
> (Linux/BSD use section 8 for admin tools, Solaris uses the
> SysV convention of section 1m for them.)
>
OK, I'll change it.
> - does this require root privileges to run? If so, ARC may
> require a RBAC entry for it. (I'm guessing yes from the
> sysi86() call in it, which ARC may also require a contract
> for as it's a private interface.)
>
Yes, it is. I'll be careful when I submit the ARC.
> - the update-pciids script requires wget, curl, or lynx, but
> none are listed in the depends file
>
In fact, this is one of the questions that I want to ask. Thanks for
bringing that up.
But I think if we don't ship pci.ids, we needn't to ship update-pciids also.
Do you think so?
> - the update-pciids script requires GNU chmod, but doesn't
> ensure that it's using /usr/gnu/bin/chmod
>
I won't ship update-pciids.
> - You leave IDSDIR set to /usr/share, and ship your own copy of
> pci.ids there - Solaris already has a bundled copy of pci.ids in
> /usr/share/hwdata - you need to use it and not add another copy
> to maintain and get out of sync. (You'll also need to add
> SUNWhwdata to the depend file.)
>
>
OK, I'll change IDSDIR to /usr/share/hwdata and add SUNWhwdata to the
depend file.
Thanks,
Chris
