Hi Paul, Thanks for your review and please see my reply.
Paul Cunningham wrote: > Christopher, > > This mainly looks good to me, see below for a few minor comments ... > > Paul > > Christopher Mi wrote: > >> Hi, >> >> Please help review this webrev for CR6794702 >> PCI Utilities to be included into SFW consolidation. >> >> http://cr.opensolaris.org/~mishuang/pciutils/ >> > > 1. usr/src/cmd/pciutils/install-sfw > You could pass the the PKGVERS= info from the Makefile.sfw where > it is extracted from the METADATA > Done. > 2. usr/src/pkgdefs/SUNWpciutils/Makefile > Delete the null DATAFILES= line > Done. > 3. usr/src/pkgdefs/SUNWpciutils/prototype_com > Shouldn't these files (f ...) be in the prototype_i386 file? > Done. I delete prototype_com and put the files in prototype_i386. > 4. prototype_* > Shouldn't there be a prototype_sparc file with an empty list? > > Do you mean I should add a empty prototype_sparc? If I understand your correctly, I don't think so, although I am not sure. I did nightly build on SPARC and i386 machines. There is no problem. The webrev, http://cr.opensolaris.org/~mishuang/pciutils, is updated. Thanks, Chris
