Christopher Mi wrote:
> Hi,
>
> Please help review this webrev for CR6794702
> PCI Utilities to be included into SFW consolidation.
>
> http://cr.opensolaris.org/~mishuang/pciutils/
- Why i386 only? SPARCs have pci busses too. Are you planning
to port in the future, or just leave it as found upstream?
- The .8 man pages need to become .1m man pages on Solaris.
(Linux/BSD use section 8 for admin tools, Solaris uses the
SysV convention of section 1m for them.)
- does this require root privileges to run? If so, ARC may
require a RBAC entry for it. (I'm guessing yes from the
sysi86() call in it, which ARC may also require a contract
for as it's a private interface.)
- the update-pciids script requires wget, curl, or lynx, but
none are listed in the depends file
- the update-pciids script requires GNU chmod, but doesn't
ensure that it's using /usr/gnu/bin/chmod
- You leave IDSDIR set to /usr/share, and ship your own copy of
pci.ids there - Solaris already has a bundled copy of pci.ids in
/usr/share/hwdata - you need to use it and not add another copy
to maintain and get out of sync. (You'll also need to add
SUNWhwdata to the depend file.)
--
-Alan Coopersmith- alan.coopersmith at sun.com
Sun Microsystems, Inc. - X Window System Engineering
