Hi again, I made yet another update to webrev to better handle the man pages; it turns out I did need an install.sfw script after all:
http://cr.opensolaris.org/~jleser/nano-2009.02.24-2 Here's hoping this is the final revision. -John John Leser wrote: > Hi Paul and Jim, > > Thank you both for your detailed comments. I've accepted and addressed > all of them (I hope), and created a new webrev: > > http://cr.opensolaris.org/~jleser/nano-2009.02.24 > > A couple of questions/comments: > > * Could somebody confirm that my copyright file is OK. The 2.0.9 nano > package includes the GPL3 in its COPYING file, and doesn't list any > specific authors or copyright dates, so I'm just including our stock > full GPL-3 text. > > * The install-sfw script turned out to be totally unnecessary, so I've > removed it. > > * Nano uses the system spell checker, which currently doesn't work at > all on OpenSolaris (buzilla 6852). I debated adding SUNWesu to the > package dependencies list, but figured since the editor can run without > it, its better to leave it out. > > * Regarding package dependencies: > > ldd /usr/bin/nano > libcurses.so.1 => /lib/libcurses.so.1 > libc.so.1 => /lib/libc.so.1 > libm.so.2 => /lib/libm.so.2 > > $ pkg search /lib/libm.so.2 > INDEX ACTION VALUE PACKAGE > path file lib/libm.so.2 pkg:/SUNWlibms at 0.5.11-0.101 > > So I added SUNWlibms to the default set to create my dependencies file. > The other two libraries are provided the default dependencies (csl > specifically). > > * I've hacked away at Makefile.sfw to get it as close as I could to the > example given to me (meld's Makefile). One specific issue is that I > left in the CFLAGS passing to the compilation steps because otherwise no > optimization flags are used. > > * I removed the test target from Makefile.sfw because the nano makefiles > don't implement it. > > > -John > > >
