Paul, Thanks again for your detailed examination. Comments in-line...
New webrev here: http://cr.opensolaris.org/~jleser/nano-2009.02.25 -John Paul Cunningham wrote: > John, > > A few more comments ... > > 1. usr/src/cmd/nano/install.sfw > Rename this to install-sfw > > Add "#!/usr/bin/ksh93" at the top > > Change ". ${SRC}/tools/install.subr" to ... > "source ${SRC}/tools/install.subr" > > Couldn't the following ... > 40 for dir in fr/man1 fr/man5 fr; do > 41 rmdir ${MANDIR}/$dir > 42 done > & > 38 rm -f ${MANDIR}/fr/${page} > just be ? ... > /bin/rm -rf fr ${MANDIR}/fr > > Add at end ... > exit 0 In response to Jim's comments, I've changed the install.sfw to do the entire install itself, rather than just correct a few files in the prototype. I was getting noise in the nightly build because the package's make install target doesn't set a lot of the permissions the way we want them. I've incorporated most of your comments, except the rm one no longer applies. > > 2. usr/src/pkgdefs/Makefile > You need to resync this with the gate > As far as I can tell, I'm in sync. I did correct one unrelated alphabetization issue in the package list. > 3. usr/src/pkgdefs/SUNWgnu-nano/copyright > Add any 'pkg owner' copyright lines, from the unpacked > src code files, after the Sun disclaimer as in ... > "http://src.opensolaris.org/source/xref/sfw/usr/src/pkgdefs/SUNWmeld/copyright"; > > Should be good now, thanks. > > 4. everything else looks okay > > Paul > [cut old stuff]
