Besides Paul's comments:
Take a look at:
http://cr.opensolaris.org/~lxin/iperf/usr/src/cmd/iperf/Makefile.sfw.html
http://cr.opensolaris.org/~lxin/iperf/usr/src/cmd/iperf/install-sfw.html
- these files have good Makefile.sfw to install-sfw interactions.
usr/src/cmd/nano/Makefile.sfw
- This:
46 $(SHELL) install.sfw
- Can be:
46 PKGDIR=$(VER) $(SHELL) ./install-sfw
usr/src/cmd/nano/install.sfw
- This:
36 _install M ${MANDIR}/${page} ${MANDIR}/${page}.temp 444
37 mv -f ${MANDIR}/${page}.temp ${MANDIR}/${page}
38 rm -f ${MANDIR}/fr/${page}
- Can be:
36 _install M ${PKGDIR}/man/${page} ${MANDIR}/${page} 444
- (ie. it should be easy to transfer the man pages from the version
directory to the proto dir)
Cheers,
Jim
Paul Cunningham wrote:
> John,
>
> A few more comments ...
>
> 1. usr/src/cmd/nano/install.sfw
> Rename this to install-sfw
>
> Add "#!/usr/bin/ksh93" at the top
>
> Change ". ${SRC}/tools/install.subr" to ...
> "source ${SRC}/tools/install.subr"
>
> Couldn't the following ...
> 40 for dir in fr/man1 fr/man5 fr; do
> 41 rmdir ${MANDIR}/$dir
> 42 done
> &
> 38 rm -f ${MANDIR}/fr/${page}
> just be ? ...
> /bin/rm -rf fr ${MANDIR}/fr
>
> Add at end ...
> exit 0
>
> 2. usr/src/pkgdefs/Makefile
> You need to resync this with the gate
>
> 3. usr/src/pkgdefs/SUNWgnu-nano/copyright
> Add any 'pkg owner' copyright lines, from the unpacked
> src code files, after the Sun disclaimer as in ...
> "http://src.opensolaris.org/source/xref/sfw/usr/src/pkgdefs/SUNWmeld/copyright";
>
>
>
> 4. everything else looks okay
>
> Paul
>
> John Leser wrote:
>>
>> I made yet another update to webrev to better handle the man pages; it
>> turns out I did need an install.sfw script after all:
>>
>> http://cr.opensolaris.org/~jleser/nano-2009.02.24-2
>>
>> Here's hoping this is the final revision.
>>
>> -John
>>
>> John Leser wrote:
>>> Hi Paul and Jim,
>>>
>>> Thank you both for your detailed comments. I've accepted and
>>> addressed all of them (I hope), and created a new webrev:
>>>
>>> http://cr.opensolaris.org/~jleser/nano-2009.02.24
>>>
>>> A couple of questions/comments:
>>>
>>> * Could somebody confirm that my copyright file is OK. The 2.0.9
>>> nano package includes the GPL3 in its COPYING file, and doesn't list
>>> any specific authors or copyright dates, so I'm just including our
>>> stock full GPL-3 text.
>>>
>>> * The install-sfw script turned out to be totally unnecessary, so
>>> I've removed it.
>>>
>>> * Nano uses the system spell checker, which currently doesn't work at
>>> all on OpenSolaris (buzilla 6852). I debated adding SUNWesu to the
>>> package dependencies list, but figured since the editor can run
>>> without it, its better to leave it out.
>>>
>>> * Regarding package dependencies:
>>>
>>> ldd /usr/bin/nano
>>> libcurses.so.1 => /lib/libcurses.so.1
>>> libc.so.1 => /lib/libc.so.1
>>> libm.so.2 => /lib/libm.so.2
>>>
>>> $ pkg search /lib/libm.so.2
>>> INDEX ACTION VALUE PACKAGE
>>> path file lib/libm.so.2 pkg:/SUNWlibms at 0.5.11-0.101
>>>
>>> So I added SUNWlibms to the default set to create my dependencies
>>> file. The other two libraries are provided the default dependencies
>>> (csl specifically).
>>>
>>> * I've hacked away at Makefile.sfw to get it as close as I could to
>>> the example given to me (meld's Makefile). One specific issue is
>>> that I left in the CFLAGS passing to the compilation steps because
>>> otherwise no optimization flags are used.
>>>
>>> * I removed the test target from Makefile.sfw because the nano
>>> makefiles don't implement it.
>>>
--
Jim Walker, http://blogs.sun.com/jwalker
Sun Microsystems, Broomfield, Colorado
