Calum Benson wrote:
>>
>> The Meld comment is:
>> "Compare and merge your files."
> 
> Sounds reasonable.  (Although I'm not sure if you period you quoted is  
> part of the Comment, or just part of your sentence... ideally,  
> Comments shouldn't end with periods.)

I can push this upstream.

> Please also run desktop-file-validate on the .desktop file to check  
> for any other issues--

bash-3.2$ desktop-file-validate meld.desktop
meld.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated
meld.desktop: warning: value "GNOME;Application;Development;" for key 
"Categories" in group "Desktop Entry" contains a deprecated value "Application"

Let me know what things I should push upstream.

Here's a cutdown version of the meld.desktop file:

+++
[Desktop Entry]
Encoding=UTF-8
Name=Meld Diff Viewer
...
Comment=Compare and merge your files.
...
Exec=meld
Terminal=false
Type=Application
Icon=meld
Categories=GNOME;Application;Development;
X-GNOME-Bugzilla-Bugzilla=GNOME
X-GNOME-Bugzilla-Product=meld
X-GNOME-Bugzilla-Component=general
+++

BTW. It looks like these warnings aren't uncommon...

desktop-file-validate users.desktop
users.desktop: warning: value "GNOME;GTK;Application;System;Settings;" for key 
"Categories" in group "Desktop Entry" contains a deprecated value "Application"
users.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated

> in particular, the format of the Icon field,  
> which should not require a full pathname or a filename extension, if  
> the application icon is correctly installed in one of the standard  
> system icon directories.  (Ideally, it should be installed in /usr/ 
> share/icons/hicolor/<size>/apps, but /usr/share/pixmaps is acceptable  
> as a last resort.

In meld.desktop, "Icon=meld", so that looks good.

The icon is stored in /usr/share/pixmaps

BTW. I get this in the terminal when I click on meld help:
OMF category 'GNOME|Application|Utility' not recognised, ignoring.

Any ideas?

Cheers,
Jim

Reply via email to