Jim,
This looks mainly okay to me. Just a few minor comments ...
1. usr/src/cmd/meld/Makefile.sfw ...
maybe you should use the predefined value for prefix from
Makefile.master, eg. something like ...
36 /usr/bin/gmake prefix=$(CFGPREFIX))
..
44 /usr/bin/gmake prefix=$(CFGPREFIX) install)
and do you need in the 'all:' rule 'DESTDIR='?
and should the 'install:' rule depend on 'all' rather than
'$(VER)/configure'?
and you might want to use "env - ..." and not "env ..."
2. usr/src/cmd/meld/install-sfw
You might want to apply 'Roland Mainz' comments to other people's
reviews to this script (look back in sfwnv-discuss for those comments).
Paul
Jim Walker wrote:
> I need a couple reviewers for the meld package.
>
> http://cr.opensolaris.org/~jwalker/meld/
>
> Thanks,
> Jim
> _______________________________________________
> sfwnv-discuss mailing list
> sfwnv-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
--
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Computer Products
