Paul Cunningham wrote: > Jim, > > This looks mainly okay to me. Just a few minor comments ... > > 1. usr/src/cmd/meld/Makefile.sfw ... > > maybe you should use the predefined value for prefix from > Makefile.master, eg. something like ... > > 36 /usr/bin/gmake prefix=$(CFGPREFIX)) > .. > 44 /usr/bin/gmake prefix=$(CFGPREFIX) install)
I agree. > and do you need in the 'all:' rule 'DESTDIR='? No, it's only used during install. I'll remove it. > and should the 'install:' rule depend on 'all' rather than > '$(VER)/configure'? I agree. > and you might want to use "env - ..." and not "env ..." Yes. That's better. > 2. usr/src/cmd/meld/install-sfw > You might want to apply 'Roland Mainz' comments to other people's > reviews to this script (look back in sfwnv-discuss for those comments). Will do. Thanks, Jim
