Hi Paul, thank you for your review.
I am currently trying to update my sfw working copy to b100 and will prepare a webrev based on that. > 1. usr/src/cmd/postgres/postgresql-8.3/METADATA done (finally... ;-) > 2. usr/src/cmd/postgres/postgresql-8.3/Makefile.sfw > Typo (out -> our) ... > 41 # out package name is postgres > > Lines 303 + 304, combines these into a single rm line. done. I will try to make VER=PKGNAME=postgresql-x.x.x, which is more consistent. > 3. usr/src/cmd/postgres/postgresql-8.3/install-sfw > & usr/src/cmd/postgres/postgresql-8.3/install-sfw-64 > The directories created in here should be in the > Targetdirs file, then they don't need creating here. OK. I've added all dirs to the Tagetdirs file, but I think we should keep the bits in install* to get the right mode bits??? At any rate, can anyone explain to me what the advantage of having a Targetdirs make include is? Would the consolidation not be easier to maintain if such things were kept within the packages' directories? > 4. usr/src/cmd/postgres/postgresql-8.3/libpqxx/Makefile.sfw > Lines 161 + 162, combines these into a single rm line. done > 5. usr/src/cmd/postgres/postgresql-8.3/libpqxx/Makefile.sfw > Do you need the "| tee make.out" bits? I haven't introduced them - removed. > 6. usr/src/pkgdefs/SUNWpostgr-83-client-root/copyright > Is this the correct content? Thanks. I've copied pkgdefs/SUNWpostgr-83-client/copyright now, which seemed most appropriate to me, but the copyright files vary a lot and I think someone who really knows about these should have al look at all of them anyway. > 7. usr/src/pkgdefs/SUNWpostgr-83-client-root/depend > This looks like the default depend file - if you have no > other dependencies then delete this file and add 'depend' > to the DATAFILES= line in > SUNWpostgr-83-client-root/Makefile. > > 8. usr/src/pkgdefs/SUNWpostgr-83-client-root/Makefile > Are these 'i.rbac r.rbac' required on the DATAFILES= line? Done and thanks a lot for these hints. I did not know about the DATAFILES macro for packages at all.
