HI Zdenek,

>> http://cr.opensolaris.org/~nigoroll/postgres_misc-rd4/
>>
>> I have updated my ws to b100. I have tried to comment each changed 
>> file with the bugs the change fixes.
> 
> I have quick comments:
> 
> 1) I discussed /etc problem with Peter Eisentraut and conclusion is that 
>  --syconfigdir should be used to correct setup a path. You already do 
> it, but this path contains version independent configuration. The 
> psqlrc.sample file is usually store in .../share/ directory.
> 
> By my opinion best solution is to set --sysconfigdir=/etc and keep 
> psqlrc.sample in current directory /usr/postgres/8.3/etc. We could 
> change psqlrc.sample to another location during 8.4 integration, but do 
> it now it seem to me as too big effort with zero benefit.

HM. Do you really mean to set --sysconfigdir=/etc or rather 
--sysconfigdir=/etc/pgsql/8.3 ? I'd prefer the latter, as I believe having a 
default dir for each (major) version is a natural consequence of having a 
basedir for each (major) version.

Why exactly do you want to avoid adding the root package and putting the sample 
config into the proper directory? Why is this "too big effort"? I'd write the 
ARC case if this is your concern.

> By the way not only Solaris has this issue. I checked SUSE and it has 
> similar problem.

Yes, but SUSE does not offer official support for diskless clients while Sun 
does for Solaris. Also, Sun claims to go for the "right solution" first, so I 
think others not implementing proper file system layouts should not be an 
excuse.

> 2) I'm still no happy with Makefile.sfw
> 
> 35 # these need to be synced manually with VERSION in METADATA
> 36 PGMAJVER=       8.3
> 37 PGMINVER=       $(COMPONENT_VERSION:sh)
> 38 PGPREFIX=       /usr/postgres/$(PGMAJVER)
> 39 PGDATAPREFIX=   /var/postgres/$(PGMAJVER)
> 
> Try somethink like: `echo "${PGMINVER}" | cut -d. -f-2`

Good idea, thank you. I'll implement something like that.

>> - So far I have neither tested the changes on sparcv9, nor have I 
>> built packages
>> and installed them (there should be an easy way to build packages 
>> which I don't
>> know - how?). Would anyone help with these?
> 
> hmmm good question. I use wrapper which do that. Try make install or cd 
> usr/src/pkgdefs; make

Make install installs everything in the proto area.

make in pkgdefs just creates the final package files, but not the packages 
itself.

>> - Who would sponsor this?
> 
> I could be, but I'm will be busy until end of October. :(

Please, would someone help out?

Nils

Reply via email to