Nils, Did a quick skip through and it looks mainly okay to me, just a few minor comments ..
Nils Goroll wrote: > > Could someone please (finally ?) review the various changes discussed in this > thread? > > http://cr.opensolaris.org/~nigoroll/postgres_misc-rd4/ My comments ... 1. usr/src/cmd/postgres/postgresql-8.3/METADATA You might want to remove the comment lines about OSR in here 2. usr/src/pkgdefs/SUNWpostgr-83-client-root/depend This is still in your webrev - I think you were going to remove it 3. usr/src/pkgdefs/SUNWpostgr-83-client-root/prototype_com Does it need the write permission bit on psqlrc.sample ? Paul > > I have updated my ws to b100. I have tried to comment each changed file with > the > bugs the change fixes. > > NEXT STEPS: > > - So far I have neither tested the changes on sparcv9, nor have I built > packages > and installed them (there should be an easy way to build packages which I > don't > know - how?). Would anyone help with these? > > - Who would sponsor this? > > some background: > > I've now got four bugs open for the various aspects which popped up while > working on what was meant to be a tiny change in the beginning. Three > bugzilla > bugs have a bugster pro-forma bug, for one I am still waiting for that. > > 6756647 pgxs / makefiles missing for 64bit postgres > http://defect.opensolaris.org/bz/show_bug.cgi?id=3298 > > 6756652 sfw postgresql makefiles.sfw / install-sfw overhaul > http://defect.opensolaris.org/bz/show_bug.cgi?id=3758 > > 6756648 sfw Makefile.master Pathname macro defintions cleanup > http://defect.opensolaris.org/bz/show_bug.cgi?id=3757 > > bugzilla 3765 sfw postgresql uses etc directory under /usr/postgres > -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
