Reid, See comments below ...
Paul Reid Kaufmann wrote: > The LSARC fast track (2008/322) has been submitted; it proposes > integrating links 0.99 into the SFW consolidation. I'm requesting a > code review for links' integration into this consolidation: > > The webrev can be found here: > http://cr.opensolaris.org/~rk142382/links/ === Start of Comments === 1. usr/src/cmd/Makefile & usr/src/pkgdefs/Makefile Why have you removed the 'removed' bits? - probably because you need to resync your ws with the gate. 2. usr/src/cmd/links/METADATA Some people put a 'URL: ....' field in here. I'm not sure what the standard set should be though. 3. usr/src/cmd/links/Makefile.sfw Why are you building this with '-g' set? You might want to consider using the predefined value for '--prefix=' from Makefile.master, see the following as an example http://cr.opensolaris.org/~rayx/erlang/webrev/usr/src/cmd/erlang/Makefile.sfw.html You are using 'gcc' to compile this, will it compile with the sun compiler instead? If you use the sun compiler you might want to consider using compiler flag ... > Roland Mainz wrote: > the "-xstrconst" puts all string literals into > read-only memory (e.g. it's shared between processes and > won't waste memory then). 4. usr/src/pkgdefs/SUNWlinks/Makefile & usr/src/pkgdefs/SUNWlinks/depend & usr/src/pkgdefs/SUNWlinks/prototype_i386 & usr/src/pkgdefs/SUNWlinks/prototype_sparc You might want to move the 'Copyright' messages to after the 'CDDL HEADER END' headers. === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products
