I updated the webrev with the changes to address the points from Steven and Paul: http://cr.opensolaris.org/~rk142382/links/
Paul, I did do a bringover to resync my workspace today. I hope that resolved the "removed bits" problem you noted -- I don't understand exactly what you're referring to. I added URL to the METADATA file. I took your suggestions in the Makefile and removed the "-g" flag since it's probably not needed (it was in there because I copied it from another sfw Makefile). GCC is required because it doesn't compile with Sun's CC. I also moved the copyright notices as you suggested. Steven, I updated to the 0.99 tarball and will use v1.0 if it doesn't require restarting the open source review from the legal dept. I had taken the latest from the sourceforge mirror, but apparently it isn't a very good mirror. With regards to links v2, the added weight and dependencies associated with the X interface is not desired. Elinks is generating some discussion and may also be integrated, but for the moment, it's not my assignment. Thanks for the feedback, and let me know if the new webrev looks ok. reid > 1. usr/src/cmd/Makefile > & usr/src/pkgdefs/Makefile > Why have you removed the 'removed' bits? - probably because you > need to resync your ws with the gate. > > 2. usr/src/cmd/links/METADATA > Some people put a 'URL: ....' field in here. I'm not sure > what the standard set should be though. > > 3. usr/src/cmd/links/Makefile.sfw > Why are you building this with '-g' set? > > You might want to consider using the predefined value for > '--prefix=' from Makefile.master... > > You are using 'gcc' to compile this, will it compile with the > sun compiler instead? > > 4. usr/src/pkgdefs/SUNWlinks/Makefile > & usr/src/pkgdefs/SUNWlinks/depend > & usr/src/pkgdefs/SUNWlinks/prototype_i386 > & usr/src/pkgdefs/SUNWlinks/prototype_sparc > You might want to move the 'Copyright' messages to after the > 'CDDL HEADER END' headers.
