URL: http://cr.opensolaris.org/~nico/webrev-sqlite3-sfw/
CRs/PSARC case: PSARC/2008/120 SQLite3.x 6665195 integrate SQLite3 into SFWNV (PSARC/2008/120) 6667082 install.subr should chown u+w before post_process* Notes: - I excluded the SQLite 3.5.4 source and docs tar balls/zip archives from the webrev -- webrev doesn't know what to do with them. - I've not yet created a suitable sub-category for 6665195. As soon as I get approval for it (and before I putback) I'll have solaris/database/sqlite3 created and I'll re-categorize 6665195. - I've not squished the SCCS deltas. I will before putting back. - Yes, I'm putting this into $SRC/cmd, rather than $SRC/lib. I could put it in $SRC/lib. But frankly, I don't think cmd vs. lib makes sense for SFW. SQLite3 includes a library (libsqlite3), Tcl bindings, and an executable (sqlite3), so does it belong in lib or cmd? - $SRC/cmd/sqlite3/install-sfw requires that elfedit(1) be present on the build system, which means that this will be a build flag day for the SFW consolidation. I found it easier to implement a mapfile for libsqlite3.so.0 via post-processing with elfedit than to modify the SQLite3 build system. See the comments in $SRC/cmd/sqlite3/Makefile.in. There was only one small change I had to make to the SQLite3 build system: a change to Makefile.in to allow the sqlite3 executable and the Tcl bindings to dynamically link with libsqlite3.so (as opposed to linking with the object files that make up libsqlite3.so, which is how SQLite3 normally builds those). - I'll separately send a heads up about this code review (with URL to this post) to storage-discuss and databases-discuss at opensolaris.org. Nico --
